DirectionsProfile for reroutes in NavigationView #575
Conversation
| @@ -157,6 +159,8 @@ private boolean launchWithRoute(NavigationViewOptions options) { | |||
| private void extractRoute(NavigationViewOptions options) { | |||
| DirectionsRoute route = options.directionsRoute(); | |||
| if (route != null) { | |||
| String profile = options.directionsProfile(); | |||
| routeProfile = profile != null ? profile : route.routeOptions().profile(); | |||
There was a problem hiding this comment.
Several checks are already in place to ensure this is never null including the MAS Directions builder and the server response itself. I've opened mapbox/mapbox-java#683 to change the annotation for this to a NonNull
There was a problem hiding this comment.
@cammace awesome, thanks for the heads up on this. The options.directionsProfile() is actually the nullable profile from the NavigationViewOptions. If it's null, we fall back to the RouteOptions profile used from the original DirectionsRoute passed in at initialization of the drop-in UI.
There was a problem hiding this comment.
Hey, it is posible to pass Locale when reroute? seems to be the answer for issue #633
There was a problem hiding this comment.
@darkwizzard PR is waiting for review #635
DirectionsRoutethe default for reroutes will be the profile from the route used to launch the UIPositioncoordinates, the default will beDirectionsCriteria.PROFILE_DRIVING_TRAFFICcc @ericrwolfe