Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maps SDK 5.5.0 #732

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Update Maps SDK 5.5.0 #732

merged 1 commit into from
Mar 5, 2018

Conversation

danesfeder
Copy link
Contributor

No description provided.

@danesfeder danesfeder merged commit fcbea51 into master Mar 5, 2018
@danesfeder danesfeder deleted the dan-maps-5.5.0 branch March 5, 2018 16:14
@baversjo
Copy link

baversjo commented Mar 5, 2018

@danesfeder Trying to get mapbox-android-navigation-ui working in my android app,
but a okhttp issue is causing your library to fail initiating.
It was fixed "for 5.5.0": mapbox/mapbox-gl-native#11371
And I believe this merge should resolve the issue in mapbox-navigation-android.
I see that https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/mapboxsdk/mapbox-android-navigation-ui/0.11.0-SNAPSHOT/ was just updated after this merge, is it supposed to contain the fix? I've tried to clear my gradle cache and specify com.mapbox.mapboxsdk:mapbox-android-navigation-ui:0.11.0-SNAPSHOT but it's still failing with the same exception:

 java.lang.NoSuchMethodError: No static method toHumanReadableAscii(Ljava/lang/String;)Ljava/lang/String; in class Lokhttp3/internal/Util; or its super classes (declaration of 'okhttp3.internal.Util' appears in 

What version of this lib is supposed to be stable?

@danesfeder
Copy link
Contributor Author

Hey @baversjo, where are you seeing this error while using the UI library? The most recent stable version is 0.10.0 but we build SNAPSHOTS (like you saw with this PR) every time we merge into master. These versions are not always stable, as master is constantly being updated / changed.

@baversjo
Copy link

baversjo commented Mar 5, 2018

@danesfeder It crashed on this line in my code (the first use of the mapbox libs):
navigation = new MapboxNavigation(this, MAPBOX_ACCESS_TOKEN);
I will try 0.10.0, thanks.

@baversjo
Copy link

baversjo commented Mar 5, 2018

@danesfeder Verified I got 0.10.0 installed, but I still get the same issue with 0.10.0. Probably because it downloads the latest version of OKHTTP? Does #738 resolve the issue you think?

@danesfeder
Copy link
Contributor Author

@baversjo yes it should. OkHTTP was updated and broke the builds. Stay tuned for that to merge and a stable 0.11.0 release if you'd rather not use the SNAPSHOT. Thanks for your patience here.

@danesfeder
Copy link
Contributor Author

@baversjo #738 just landed. Keep an eye out for 0.11.0

@danesfeder danesfeder mentioned this pull request Mar 7, 2018
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants