Send departure event with a valid distance traveled #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Mar 22, 2018
| if (navigationSessionState.startTimestamp() == null) { | ||
| boolean isValidDeparture = navigationSessionState.startTimestamp() == null | ||
| && routeProgress.currentLegProgress().distanceTraveled() > 0; | ||
| if (isValidDeparture) { | ||
| // Set departure timestamp |
There was a problem hiding this comment.
Unnecessary comment.
danesfeder
force-pushed
the
dan-telem-bug
branch
from
c15f5ff to
0785874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing the first location update caused the departure event to fire without a valid location. So departure events were firing from null island
0,0. This PR adds a check to ensure we have a valid distance traveled before we send the event.