Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding the top instructions banner breaks animations #2165

Closed
johnnewman opened this issue Jun 27, 2019 · 3 comments · Fixed by #2185
Closed

Expanding the top instructions banner breaks animations #2165

johnnewman opened this issue Jun 27, 2019 · 3 comments · Fixed by #2185
Assignees
Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Comments

@johnnewman
Copy link

Mapbox Navigation SDK version: 0.35.0

When the default instruction banner view is expanded, the instruction labels can animate incorrectly as they are appearing. They can be seen growing from the 0,0 origin.

The offset of the map also seems to change, causing it to recenter to the user's location after closing the instructions. You can see the circular route and volume buttons moving with the banner change as well.

I am supplying nil as the topBanner to NavigationOptions.

Here is a zip of a screen recording showing the issues: Banner.MOV.zip

@JThramer JThramer self-assigned this Jun 27, 2019
@JThramer
Copy link
Contributor

@johnnewman Thanks for reporting! Will look into this ASAP.

@JThramer JThramer added bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. user: feature request labels Jun 27, 2019
@johnnewman
Copy link
Author

johnnewman commented Jul 29, 2019

Thank you for looking into this! After trying out the changes in 0.36.0, the labels appear fixed, but I am still seeing:

The offset of the map also seems to change, causing it to recenter to the user's location after closing the instructions. You can see the circular route and volume buttons moving with the banner change as well.

@1ec5
Copy link
Contributor

1ec5 commented Jul 29, 2019

Good to hear that the labels are fixed. I didn’t notice the bit about the map offset until now – thanks for following up. This sounds like what we’re tracking in #2145, which is ultimately caused by mapbox/mapbox-gl-native#15233.

astojilj added a commit that referenced this issue Aug 12, 2019
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change.

Remove the need to specify center for puck view - use the approach where content inset is keeping it centered.

Take safeArea into account when calculating contentInsets.

Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233

Related to: #2165,

Fixes: #2145
astojilj added a commit that referenced this issue Sep 9, 2019
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change.

Remove the need to specify center for puck view - use the approach where content inset is keeping it centered.

Take safeArea into account when calculating contentInsets.

Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233

Related to: #2165,

Fixes: #2145
1ec5 pushed a commit that referenced this issue Oct 2, 2019
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change.

Remove the need to specify center for puck view - use the approach where content inset is keeping it centered.

Take safeArea into account when calculating contentInsets.

Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233

Related to: #2165,

Fixes: #2145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants