-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding the top instructions banner breaks animations #2165
Comments
@johnnewman Thanks for reporting! Will look into this ASAP. |
Thank you for looking into this! After trying out the changes in
|
Good to hear that the labels are fixed. I didn’t notice the bit about the map offset until now – thanks for following up. This sounds like what we’re tracking in #2145, which is ultimately caused by mapbox/mapbox-gl-native#15233. |
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change. Remove the need to specify center for puck view - use the approach where content inset is keeping it centered. Take safeArea into account when calculating contentInsets. Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233 Related to: #2165, Fixes: #2145
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change. Remove the need to specify center for puck view - use the approach where content inset is keeping it centered. Take safeArea into account when calculating contentInsets. Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233 Related to: #2165, Fixes: #2145
Decouple dependency content insets -> anchor point -> padding/content insets broken after mapbox/mapbox-gl-native#14664 introduced animated interpolation for padding change. Remove the need to specify center for puck view - use the approach where content inset is keeping it centered. Take safeArea into account when calculating contentInsets. Addresses: mapbox/mapbox-gl-native#15232, mapbox/mapbox-gl-native#15233 Related to: #2165, Fixes: #2145
Mapbox Navigation SDK version: 0.35.0
When the default instruction banner view is expanded, the instruction labels can animate incorrectly as they are appearing. They can be seen growing from the 0,0 origin.
The offset of the map also seems to change, causing it to recenter to the user's location after closing the instructions. You can see the circular route and volume buttons moving with the banner change as well.
I am supplying
nil
as thetopBanner
toNavigationOptions
.Here is a zip of a screen recording showing the issues: Banner.MOV.zip
The text was updated successfully, but these errors were encountered: