-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No voice instruction, top banner not update #2240
Comments
Update: If we change the the RouteController in NavigationService to LegacyRouteController like below index 47d8132..bc44ed7 100644
--- a/ios/Pods/MapboxCoreNavigation/MapboxCoreNavigation/NavigationService.swift
+++ b/ios/Pods/MapboxCoreNavigation/MapboxCoreNavigation/NavigationService.swift
@@ -127,7 +127,7 @@ public protocol NavigationService: CLLocationManagerDelegate, RouterDataSo
@objc(MBNavigationService)
public class MapboxNavigationService: NSObject, NavigationService, DefaultInterfaceFlag {
- typealias DefaultRouter = RouteController
+ typealias DefaultRouter = LegacyRouteController
/**
The default time interval before beginning simulation when the `.onPoorGPS` simulation Then it will work, is there any issue with this change? |
Any update on this issue?
No voice update is getting. |
are you using |
Hi @andrlee , I'm using But I'm able to get the voice instruction in pod version
|
Hi @andrlee ,
|
I am unable to reproduce this in the example app. It's interesting that the How are you configuring your access token? Are you setting |
@JThramer for me, I'm setting |
We've checked with v0.38, the issue is still there. |
Same here with version 0.38. no instruction update and no voice command but the LegacyRouteController works which is not ideal solution. |
Thank you @luugiathuy modifying that part of the code saved me. Just need to mention beside fixing voice and banner, also fixed rerouting problem. Mapbox please fix this since this rerouting issue has a direct connection to our pocket. No one wants to finish 100,000 free limit in 1 navigation trip. |
@PriyeshMohan Are you seeing this occurring in the SDK example project? If not, are you able to share more of the code that is reproducing the issue? Can you share a starting/ending coordinate for the original route that is being calculated? |
Just copy/past the method mentioned in this issue and most probably your instruction update and voice command will work as expected and no need to modify SDK as @luugiathuy mentioned here |
@soheilnikbin you meant this block of code?
I tried but it did not work. Also I think this should be default behavior when we not implement this delegate function. |
@luugiathuy Just now I was testing navigation after pod update to make sure is working fine but voice command and routing instruction stop working, so then I added back |
When you create the RouteOptions or NavigationRouteOptions object, are you setting the By the way, if you do need to use LegacyRouteController, you can enable it without forking this repository or monkey-patching the SDK: let navigationService = MapboxNavigationService(route: route, routerType: LegacyRouteController.self)
let navigationOptions = NavigationOptions(navigationService: navigationService)
let navigationViewController = NavigationViewController(for: route, options: navigationOptions) |
@1ec5 we set the Thanks for the workaround of setting LegacyRouteController, it's better than monkey-patching the SDK. |
Can you provide example origin and destination coordinates for a route where this issue occurs when you don’t use the LegacyRouteController workaround? I’m curious whether there’s something in the Directions API response in a specific area that’s causing MapboxNavigationNative to silently consider the route invalid. |
@1ec5 I was testing in Singapore area. |
Unfortunately, I’m unable to reproduce the issue simulating routes around Singapore with the default RouteController. Could you share a reduced test case of the problem, including the origin and destination coordinates and any other settings you specified on NavigationRouteOptions? (If you prefer to share this information privately, please contact the Mapbox Support team and let them know you’re following up on this ticket.) Thank you! |
Were any of you seeing this issue in an application that was running in Arabic, Burmese, Chinese, Esperanto, Finnish, Hebrew, Hungarian, Indonesian, Slovenian, Ukrainian, or Vietnamese? Per #2336 (comment), the underlying navigator component can get stuck after requesting directions in a language that the Mapbox Voice API doesn’t support (requiring the navigation SDK to fall back to VoiceOver or a third-party text-to-speech engine). To confirm that this is the root cause, set a breakpoint here and check whether
If this is the case for you, there are two workarounds: you can either switch to LegacyRouteController, as explained in #2240 (comment), or you can upgrade to v1.0.0-alpha.1, which happens to avoid the bug in MapboxNavigationNative that causes it to get stuck on these languages. |
@1ec5 I was trying the example in the
|
That crash is #2299, which is unrelated to the issue you reported originally. v0.38.1 and v0.38.3 should be equivalent when it comes to location tracking and spoken instructions. master and v1.0.0-alpha.1 are also unaffected by #2336, so if you can reproduce the original issue in v0.x but not master, that would also corroborate that theory to some extent. |
Please open a new issue if you continue to experience this issue. There have been enough significant changes to the navigation SDK and its dependencies since the original report that a similar set of symptoms might well be a coincidence at this point. |
Mapbox Navigation SDK version: 0.37
Device: iPads
We encountered an issue with voice instruction and top banner for our apps, there is no voice instruction even though we turned on the volume in app and the device. The top banner is not updated as well.
I have downloaded the Example app and run on simulators (iOS 12.4) and it also has the same issue with simulated locations. Do I need to configure anything to turn on the voice instruction?
The text was updated successfully, but these errors were encountered: