Add option to config max width of scalebar.

[Chaoba]

Resolves #1046
ratio is calculated according scalebar with / mapview width.
Currently we add support for HALF, THIRD and QUATER, may add more if needed in future.

[LukasPaczos]

How about allowing developers to specify any arbitrary ratio or pixel width (out of which we'll calculate the ratio) instead of hardcoding a couple of values?

[Chaoba]

I have the same thoughts at first, the current implementation is based on the following reasons:

1. The defined values is more clear and straightforward.
2. No need to add checks to insure the passed in param is valid.
3. Prevent the corner scenarios like text overlapping.

[tobrun]

The defined values is more clear and straightforward.

Being able to define a maxWidth configuration will be more flexible as it will cater to all use-cases / designs. I feel, if a user wants a scalebar of max 30 pixels, they should be able to configure that.

[Chaoba]

@tobrun Consider of adaption for difficult devices, I believe use ratio is better than pixels. So, how about we let user set the a ratio in 0.1 ~ 1?

[tobrun]

Consider of adaption for difficult devices, I believe use ratio is better than pixels.

Android view system is build up around pixels. To support variety of device screen sizes, we do have the concept of dp values but that is only used in xml resources. In code you always use pixels. I'm personally not seeing with using pixels.

[virtuoso80]

Hi, any update?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale]

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[tobrun]

@Chaoba can you resolve conflicting files, let's merge as is and revisit the pixel configuration later?