Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin LocationPicker #208

Closed
wants to merge 6 commits into from
Closed

Conversation

bkhezry
Copy link

@bkhezry bkhezry commented Dec 5, 2017

#41
image

pick the location from Mapbox map and return coordinates with an address of it from reverse geocode.
TODO: add search service that can find the location by name.

@zugaldia @tobrun

@zugaldia
Copy link
Member

zugaldia commented Dec 5, 2017

Look who's back :) Thank you @bkhezry for yet another contribution!

I'm tagging @cammace for PR review because he wrote our original location picker, and also @langsmith in case it's worth adopting this plugin in the demo app and update the current example.

@zugaldia zugaldia requested a review from cammace December 5, 2017 15:48
@cammace
Copy link

cammace commented Dec 8, 2017

thank you for this contribution @bkhezry this could be a great addition to the places plugin which recently got merged, let's us investigate the best way forward, we'll post back when we know more.

@cammace
Copy link

cammace commented Feb 16, 2018

@bkhezry, thank you so much for this contribution. I extracted some of the ideas brought up from your PR and merged a Place Picker activity into master (in #262). It will be ready for use in your app with the next places plugin release. Let me know if you have any questions.

@cammace cammace closed this Feb 16, 2018
@bkhezry
Copy link
Author

bkhezry commented Feb 17, 2018

@cammace thank you :-), I'll see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants