Location layer asset update #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
force-pushed
the
location-layer-asset-update
branch
from
d6e44b9 to
a2beeb7
Compare
cammace
added
ready for review
tobrun
reviewed
Jan 25, 2018
| private void addCameraListener() { | ||
| if (locationLayerMode == LocationLayerMode.NAVIGATION) { | ||
| mapboxMap.removeOnCameraMoveListener(this); | ||
| return; |
There was a problem hiding this comment.
it's a bit strange that a method called #addCameraListener is actually removing the listener in some cases. Either rename the method to something fitting or decouple the removal into a separate codeblock
| @@ -496,6 +504,8 @@ private void setNavigationLayerVisibility(boolean visible) { | |||
| @Override | |||
| public void onCameraMove() { | |||
| locationLayer.updateAccuracyRadius(location); | |||
| locationLayer.updateForegroundOffset(mapboxMap.getCameraPosition().tilt); | |||
| locationLayer.updateForegroundBearing((float) mapboxMap.getCameraPosition().bearing); | |||
There was a problem hiding this comment.
reuse the CameraPosition object, now we are calling twice into c++ code while we can get away with just once.
|
Thanks for the review, made the changes @tobrun |
tobrun
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#This PR optimizes/updates some of the location layer assets. The main difference is now we are adding a more 3D effect to the icons so that the user location pops out more and is easier to find (especially on a white background).
I've also fixed an issue with the accuracy layer getting initialized with the default radius of 5 and then immediately going back to zero since the
locationvariable was null.lastLocationvariable has been removed sincelocationis virtually identical.