Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel animation as part of stopping the animation #247

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Cancel animation as part of stopping the animation #247

merged 1 commit into from
Jan 18, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jan 17, 2018

This PR hardens the LocationLayerPlugin#stopAllAnimations() integration by cancelling the animation and removing all listeners (not only the update listeners).

@tobrun tobrun added the location-layer-plugin Issues that deal with the location layer module label Jan 17, 2018
@tobrun tobrun added this to the location-layer-0.4.0 milestone Jan 17, 2018
@tobrun tobrun self-assigned this Jan 17, 2018
@tobrun tobrun requested a review from cammace January 17, 2018 14:37
@tobrun
Copy link
Member Author

tobrun commented Jan 17, 2018

@cammace I'm hitting:

* What went wrong:
Execution failed for task ':sonarqube'.
> No quality profiles have been found, you probably don't have any language plugin installed.

any idea?

@cammace
Copy link

cammace commented Jan 18, 2018

Fixed and rerunning.

@cammace cammace merged commit bea4e19 into master Jan 18, 2018
@cammace cammace deleted the tvn-cancel-animation-location-layer branch January 18, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

Assignees

@tobrun tobrun

Labels
location-layer-plugin Issues that deal with the location layer module
Projects
None yet
Milestone
location-layer-0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @cammace