Initial stale logic added #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
ready for review
tobrun
reviewed
Feb 8, 2018
| private Handler handler; | ||
| private long delayTime = DEFAULT_DELAY_TIME_TILL_STALE; | ||
|
|
||
| static StaleStateRunnable getInstance() { |
There was a problem hiding this comment.
is there are reason why this class is a singleton? can't we get away with using a final field in the plugin instead?
|
|
||
| private StaleStateRunnable() { | ||
| onLocationStaleListeners = new ArrayList<>(); | ||
| handler = new Handler(); |
There was a problem hiding this comment.
these can be directly initialised as part of the field declaration + they can be made final
added 3 commits
February 13, 2018 12:34
* adds location layer options class * Fixed memory leak in manual location update activity * Remove stale state listener in onStop * add elevation attribute * fix accuracy showing during nav mode * added documentation to location options * added some test for the class * fixed test * set locationlayermode at beginning of method * remove toggleCameraListener param
tobrun
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58