Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable/disable inside lifecycle methods #528

Merged
merged 1 commit into from
May 22, 2018
Merged

enable/disable inside lifecycle methods #528

merged 1 commit into from
May 22, 2018

Conversation

cammace
Copy link

@cammace cammace commented May 21, 2018

Closes #509

prevents people from passing in location updates post onStop call.

@cammace cammace added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label May 21, 2018
@cammace cammace added this to the location-layer-0.5.3 milestone May 21, 2018
@cammace cammace self-assigned this May 21, 2018
@cammace cammace requested review from zugaldia and tobrun May 21, 2018 17:05
@zugaldia zugaldia removed their request for review May 21, 2018 20:31
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cammace cammace merged commit 1225652 into master May 22, 2018
@cammace cammace deleted the cam-509 branch May 22, 2018 16:26
@cammace cammace mentioned this pull request May 23, 2018
11 tasks
LukasPaczos pushed a commit that referenced this pull request May 30, 2018
LukasPaczos pushed a commit that referenced this pull request May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review When your PR has been personally reviewed, its time for an external contributors to approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants