Expose icon scale option #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
the
location-layer-plugin
cammace
suggested changes
May 30, 2018
| @@ -34,6 +34,10 @@ | |||
| <attr name="mapbox_maxZoom" format="float"/> | |||
| <attr name="mapbox_minZoom" format="float"/> | |||
|
|
|||
| <!-- Icon scale based on map zoom levels --> | |||
| <attr name="mapbox_maxZoomIconScale" format="float"/> | |||
There was a problem hiding this comment.
These also need to be publically exposed in the public_attrs.xml file.
| */ | ||
| public abstract Builder minZoom(@FloatRange(from = MapboxConstants.MINIMUM_ZOOM, | ||
| to = MapboxConstants.MAXIMUM_ZOOM) double minZoom); | ||
|
|
||
| /** | ||
| * Sets the scale factor of the location icon when the map is zoomed in. Based on {@link #maxZoom()}. | ||
| * Scaling is linear. |
There was a problem hiding this comment.
Maybe also worth mentioning the scaling is measured in pixels like the iconSize property docs mention
LukasPaczos
force-pushed
the
530-expose-scale-option
branch
from
9ed99f7 to
4a3aee3
Compare
|
Ready for another round @cammace. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #530. I targeted this changes at
v0.6.0, let me know if you'd rather see it asv0.5.4.This PR also modifies
LocationLayerMapChangeActivityto use internalLocationEngine.