Showing accuracy for forced location

[LukasPaczos]

Refs #469.

[LukasPaczos]

I initially misinterpreted #469 - it points out that accuracy circle doesn't animate when the new location (with different accuracy than previous) is provided, it just jumps to the required value.

#469 (comment) still stands and is fixed by this PR.

[danesfeder]

@LukasPaczos just a clarifying comment. Per #572 (comment), you're saying the animation from different accuracies is fixed, but animate when the new location (with different accuracy than previous) is provided is still an issue? Thanks for running with this!

[danesfeder]

@LukasPaczos Per javadoc above - here we are trying to get the last known location from the location engine and if nothing is found, using lastLocation which could also possibly be null? Just clarifying here, I think it makes sense to add the extra check in case a developer was forcing Location updates.

[LukasPaczos]

Yes, lastLocation can also be null if no updates have been pushed to the plugin yet. This is our last resort if locationEngine is null or fails to provide non-null location, like a scenario when we are only forcing location updates.

The idea here is, that LocationEngine can be in a position to provide last location (or just more recent location) even if no location updates have been pushed to the plugin itself.

[LukasPaczos]

you're saying the animation from different accuracies is fixed

Unfortunately, no. This is something I'm working on right now. This PR fixes an issue which occurred when you didn't use locationEngine (only forcing location updates) and zoomed in/out - then accuracy would be gone. We are using getLastKnownLocation to recalculate the radius for a new zoom level, and it would always return null, because there was no engine. Now we have lastLocation variable to fall back to.

[danesfeder]

@LukasPaczos got it, thanks for clarifying - 🚢 ✅