Animate accuracy ring when new value is provided #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
the
location-layer-plugin
danesfeder
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
@LukasPaczos this looks great, one minor comment not blocking the PR 
| private void playAccuracyRadiusAnimators(long duration) { | ||
| List<Animator> accuracyAnimators = new ArrayList<>(); | ||
| accuracyAnimators.add(accuracyRadiusAnimator); | ||
| AnimatorSet accuracyAnimatorSet = new AnimatorSet(); |
There was a problem hiding this comment.
@LukasPaczos do we need to create an AnimatorSet here if the accuracyRadiusAnimator is the only one being added?
LukasPaczos
force-pushed
the
469-new-accuracy-animation
branch
from
bbf2ba6 to
d5b7992
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469.