-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps SDK bump to 6.4.0 #615
Conversation
@danesfeder @LukasPaczos @tobrun Something weird is going on with this bump and Firebase 🤔 . I've re-run the tests in CircleCI a couple of times, but it doesn't help. Have you seen this issue recently with prs in this repo? |
The issue is that the source is |
Taking above back, it's actually the query that returns an empty list. |
Any next steps? |
…fore the first location fix
f648409 adjusts for a change that was introduced in mapbox/mapbox-gl-native#12529 which resulted in sources that are barely out of the camera view not being pre-fetched anymore, and since we have a minimum zoom level of 2, the edge of the last tile is out of view and we have no data about a feature that was set to f648409 hides the layer instead, until the first location update is provided. @danesfeder would you mind 👀 this PR as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke with @LukasPaczos about #615 (comment) and sounds like some solid improvements to the lifecycle logic. Also tested locally and everything looked 💯. Thanks for the work and debugging on the @langsmith @LukasPaczos
Part of the Maps SDK 6.4.0 release