Add LocationLayer unit tests #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
ready for review
danesfeder
force-pushed
the
dan-locationlayer-tests
branch
3 times, most recently
from
50f11b9 to
d414782
Compare
LukasPaczos
reviewed
Aug 28, 2018
| float gpsBearing = 2f; | ||
| layer.onNewGpsBearingValue(gpsBearing); | ||
|
|
||
| verify(locationFeature).addNumberProperty(anyString(), eq(gpsBearing)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
| float gpsBearing = 2f; | ||
| layer.onNewGpsBearingValue(gpsBearing); | ||
|
|
||
| verify(locationFeature, times(0)).addNumberProperty(anyString(), eq(gpsBearing)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
| float compassBearing = 2f; | ||
| layer.onNewCompassBearingValue(compassBearing); | ||
|
|
||
| verify(locationFeature).addNumberProperty(anyString(), eq(compassBearing)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
| float compassBearing = 2f; | ||
| layer.onNewCompassBearingValue(compassBearing); | ||
|
|
||
| verify(locationFeature, times(0)).addNumberProperty(anyString(), eq(compassBearing)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
| float accuracyRadiusValue = 2f; | ||
| layer.onNewAccuracyRadiusValue(accuracyRadiusValue); | ||
|
|
||
| verify(locationFeature).addNumberProperty(anyString(), eq(accuracyRadiusValue)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
| float accuracyRadiusValue = 2f; | ||
| layer.onNewAccuracyRadiusValue(accuracyRadiusValue); | ||
|
|
||
| verify(locationFeature, times(0)).addNumberProperty(anyString(), eq(accuracyRadiusValue)); |
There was a problem hiding this comment.
Could we use the properties constants instead of anyString()?
danesfeder
force-pushed
the
dan-locationlayer-tests
branch
3 times, most recently
from
0c5c38c to
f286b4a
Compare
danesfeder
force-pushed
the
dan-locationlayer-tests
branch
from
f286b4a to
40a5638
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.