Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix astronaut demo scene shader for mobile platforms #1385

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

brnkhy
Copy link
Contributor

@brnkhy brnkhy commented Jun 4, 2019

fix astronaut scene building shader for mobile devices.

error was;
duplicate system value semantic definition: input semantic 'SV_POSITION' and input semantic 'VPOS'

I removed VPOS definition from shader, which was created using amplify shader editor. tested for android build (just created build package, couldn't run it) and windows editor/build.

@atripathi-mb @jordy-isaac

@brnkhy
Copy link
Contributor Author

brnkhy commented Sep 13, 2019

@atripathi-mb @jordy-isaac this should be safe to merge as well but would be cool if one of you can quickly create an android build and see if it goes through.

@abhishektrip abhishektrip merged commit 6286a64 into develop Sep 14, 2019
@brnkhy brnkhy deleted the shaderFix branch September 25, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants