Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning cleanup #1465

Merged
merged 8 commits into from
Sep 17, 2019
Merged

Warning cleanup #1465

merged 8 commits into from
Sep 17, 2019

Conversation

abhishektrip
Copy link
Contributor

@abhishektrip abhishektrip commented Sep 17, 2019 •
edited
Loading

Description of changes

  • Fix warnings
  • Fix errors when building to device.
  • Fix errors with prefabs when importing in 2019+ versions.

QA checklists

  • Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • Add tests for new/changed/updated classes and methods!!!
  • Check out conventions in CONTRIBUTING.md.
  • Check out conventions in CODING-STYLE.md
  • Update the changelog
  • Update documentation.

Reviewers

Tag your reviewer(s). Choose wisely.

@abhishektrip abhishektrip requested a review from brnkhy September 17, 2019 22:56
@abhishektrip abhishektrip merged commit ec79d10 into develop Sep 17, 2019
@abhishektrip abhishektrip deleted the warning-cleanup branch October 15, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brnkhy brnkhy Awaiting requested review from brnkhy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhishektrip