Added Windows support. Tests now pass on Windows. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added windows file path support. Added constructor options to set batch size without using a query string. Still works as previous version did. You can still pass a URL object or a URL string.
|
Thanks very much for the patch. All tilelive modules have this issue on windows and I've dodged it in various ugly ways (cutting-room-floor/tilestream@93a838c) in the past. Also there is mapbox/tilelive#40. Are you also needing support in other tilelive modules? Or just node-mbtiles? |
|
Right now I only need Windows support for node-mbtiles. I'm sure in the future I may look at other modules. |
|
This PR is too old. now close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added windows file path support.
Added constructor options to set batch size without using a query
string.
Still works as previous version did. You can still pass a URL object or
a URL string.