Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extraction of polygon coordinates #65

Closed
wants to merge 2 commits into from

Conversation

hwbllmnn
Copy link

This should fix #64 . Prior to this, for a given list of polygons from geojson write would have been called with one geometry (containing all other polygons) and n property objects, so only a single (multi-)geometry would be saved, but n entries in the .dbf.

@newmanw
Copy link

newmanw commented Oct 26, 2018

This fixes a bunch of outstanding issues. Any updates on if/when this will be merged in?

kellyi pushed a commit to azavea/shp-write that referenced this pull request Dec 17, 2018
To fix issues related to parsing polylines, polygons, and points add
patches from

- mapbox#44 (comment)
- mapbox#65

Signed-off-by: Kelly Innes <[email protected]>
@NickDarvey
Copy link

Is this repository still being maintained and is this likely to be merged?

(We're looking for the fix to #66)

@hwbllmnn
Copy link
Author

I don't think so. I've opened a maintenance branch at https://github.com/hwbllmnn/shp-write/tree/maintenance with some fixes I needed, feel free to use that one. If you have other issues/fixes feel free to do so at my fork, I'd be willing to do a little maintaining of my own.

@aleffabricio
Copy link

Hello @hwbllmnn, is it possible to merge solution #75 with your fork?

@hwbllmnn
Copy link
Author

Sure, feel free to open a PR against the maintenance branch.

@hwbllmnn
Copy link
Author

I don't think so. I've opened a maintenance branch at https://github.com/hwbllmnn/shp-write/tree/maintenance with some fixes I needed, feel free to use that one. If you have other issues/fixes feel free to do so at my fork, I'd be willing to do a little maintaining of my own.

Closing this PR as it won't be merged here.

@hwbllmnn hwbllmnn closed this Oct 18, 2021
@sheindel
Copy link
Contributor

Hi all! I've been in discussion with the team from Mapbox and they've agreed to let me help take over some of the maintenance of this repo. I'd like to see some of these clearly important PRs merged in but I'll need some time to familiarize myself with them. Thanks for all the work you've all added so far and hopefully we can resurrect these projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: In final shapefile, I get less geometries than dbf rows.
5 participants