Rewrite Core Location shim for Linux #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrote the Core Location compatibility shim for Linux to define non-CL-prefixed types regardless of platform, allowing for more consistent usage across platforms.
1ec5
added
op-ex
|
This PR looks frighteningly large, but most of it is just removing the |
macdrevx
approved these changes
Feb 5, 2021
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the Core Location compatibility shim for Linux to define non-CL-prefixed types regardless of platform. For example, cross-platform code uses
LocationCoordinate2Dinstead ofCLLocationCoordinate2D, but Apple-platform code can continue to useCLLocationCoordinate2D.Along the way, this PR also renames
BoundingBox(_:_:)toBoundingBox(southWest:northEast:)to avoid mistakes similar to #102 in client code.Fixes #119.
/cc @mapbox/navigation-ios @macdrevx