Add Polygon simplify #138
Merged
Add Polygon simplify #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okcoker
force-pushed
the
feature/polygon-simplify
branch
from
8bd2e1e to
93939d9
Compare
Udumft
reviewed
Mar 15, 2021
| } | ||
|
|
||
| /** | ||
| * Returns true if ring has at least 3 coordinates and its first coordinate is the same as its last |
There was a problem hiding this comment.
This description does not match the logic of the function: if a ring has 3 coordinates, and it's first and last coordinates are equal - it will return false. Thus, the function checks first and last coordinates only for 3-points rings.
There was a problem hiding this comment.
Ah yes the original comment set me up for failure. Just pushed an update.
Udumft
approved these changes
Mar 16, 2021
okcoker
force-pushed
the
feature/polygon-simplify
branch
from
2247bdc to
a345fb1
Compare
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Polygon simplify.
The expected output numbers had to be altered with more precision from what you see here
I noticed this was done with the
LineStringtests as well.