Add support for Sendable #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
force-pushed
the
feature/sendable
branch
from
2d36449 to
02d50b0
Compare
azarovalex
force-pushed
the
feature/sendable
branch
from
f3120d4 to
fae5cd2
Compare
azarovalex
requested review from
Udumft and
OdNairy
and removed request for
Udumft
azarovalex
force-pushed
the
feature/sendable
branch
from
104012b to
2e4cccb
Compare
Udumft
approved these changes
Jan 3, 2024
OdNairy
approved these changes
Jan 8, 2024
Package.swift
Outdated
Comment on lines
35
to
45
| //for target in package.targets where target.type != .system { | ||
| // target.swiftSettings = target.swiftSettings ?? [] | ||
| // target.swiftSettings?.append( | ||
| // .unsafeFlags([ | ||
| // "-emit-module-interface", "-enable-library-evolution", | ||
| // "-Xfrontend", "-warn-concurrency", | ||
| // "-Xfrontend", "-enable-actor-data-race-checks", | ||
| // "-Xfrontend", "-require-explicit-sendable", | ||
| // ]) | ||
| // ) | ||
| //} |
Comment on lines
+45
to
+49
| - build_and_test_linux | ||
| - build_and_test_macos: | ||
| matrix: | ||
| parameters: | ||
| xcode_version: [13.4.1, 14.3.1, 15.1.0] |
There was a problem hiding this comment.
Should we add a build_for_library_evolution job to the list as well?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All public types are marked as Sendable.
Additionally replacing Travis with CircleCI for consistency with other Mapbox projects.