Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider following the Protocol Buffer style guide #3

Closed
paulmach opened this issue Apr 13, 2014 · 3 comments
Closed

Consider following the Protocol Buffer style guide #3

paulmach opened this issue Apr 13, 2014 · 3 comments

Comments

@paulmach
Copy link

Protocol Buffers offers a style guide for .proto files. Please consider following it.
https://developers.google.com/protocol-buffers/docs/style
@springmeyer
Copy link

Awesome, thanks will review and incorporate asap.

@sgillies
Copy link
Contributor

sgillies commented May 6, 2014

@springmeyer the work would entail:

  • change message tile to message Tile, message feature to message Feature, message layer to message Layer, and message value to message Value.
  • upper case the GeomType enums, Point to POINT etc.

The field names in vector_tile.proto suit the style guide already.

@strk
Copy link

strk commented Jul 28, 2014

The upper casing of enums would also fix this problem I'm having with protoc-c:
protobuf-c/protobuf-c#152

@strk strk mentioned this issue Jul 28, 2014
Closed
springmeyer pushed a commit that referenced this issue Jul 28, 2014
Merge pull request #17 from mapbox/protobuf-style
66740c4 
Follow protobuf style guide in proto - closes #3
springmeyer pushed a commit that referenced this issue Jul 28, 2014
add changelog + move changes from #3/#17 into new version
b7941e5
@jfirebaugh jfirebaugh mentioned this issue Dec 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@springmeyer @sgillies @strk @paulmach