Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image simiarity test #3008

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Fix image simiarity test #3008

merged 8 commits into from
Aug 15, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jul 26, 2023

Don't ignore small changes

@sbrunner sbrunner requested a review from sebr72 July 26, 2023 16:19
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch 15 times, most recently from 281cc17 to 35f92a3 Compare July 28, 2023 09:42
@sbrunner sbrunner marked this pull request as ready for review July 28, 2023 12:21
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch 4 times, most recently from a051594 to 3e8ae79 Compare August 3, 2023 08:56
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch 2 times, most recently from 278f9ea to 722aa83 Compare August 3, 2023 10:38
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed when you have a moment

@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch from 722aa83 to e84052b Compare August 3, 2023 11:55
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch 2 times, most recently from 444d733 to 7d0ea87 Compare August 14, 2023 11:40
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch 4 times, most recently from 396d423 to ac026b6 Compare August 14, 2023 15:48
@sbrunner sbrunner force-pushed the fix-image-simiarity-test branch from ac026b6 to 6d50b7a Compare August 14, 2023 16:07
Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.
I will create an issue to remove the magic number 1 in asssertions of ImageSimilarity.

@sebr72 sebr72 merged commit bee1eed into master Aug 15, 2023
@sebr72 sebr72 deleted the fix-image-simiarity-test branch August 15, 2023 08:02
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants