-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image simiarity test #3008
Merged
Merged
Fix image simiarity test #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
281cc17
to
35f92a3
Compare
a051594
to
3e8ae79
Compare
sebr72
reviewed
Aug 3, 2023
core/src/main/java/org/mapfish/print/test/util/ImageSimilarity.java
Outdated
Show resolved
Hide resolved
sebr72
reviewed
Aug 3, 2023
278f9ea
to
722aa83
Compare
sebr72
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed when you have a moment
core/src/main/java/org/mapfish/print/test/util/ImageSimilarity.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/mapfish/print/test/util/ImageSimilarityTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/mapfish/print/test/util/ImageSimilarityTest.java
Outdated
Show resolved
Hide resolved
examples/src/test/resources/examples/oereb/expected_output/requestData.png
Outdated
Show resolved
Hide resolved
...nter_wms1_0_0_flexiblescale_area_of_interest/output/expectedSimpleImage-none-transparent.png
Outdated
Show resolved
Hide resolved
examples/src/test/resources/examples/simple_A0/expected_output/requestData.png
Outdated
Show resolved
Hide resolved
...ources/org/mapfish/print/processor/map/scalebar/expected-scalebar-bar-vertical-text-left.png
Outdated
Show resolved
Hide resolved
...urces/org/mapfish/print/processor/map/scalebar/expected-scalebar-bar-vertical-text-right.png
Outdated
Show resolved
Hide resolved
722aa83
to
e84052b
Compare
444d733
to
7d0ea87
Compare
396d423
to
ac026b6
Compare
ac026b6
to
6d50b7a
Compare
sebr72
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
I will create an issue to remove the magic number 1 in asssertions of ImageSimilarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ignore small changes