Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support newer Gradle versions #390

Merged
merged 9 commits into from
May 17, 2024
Merged

Support newer Gradle versions #390

merged 9 commits into from
May 17, 2024

Conversation

Fabi755
Copy link
Contributor

@Fabi755 Fabi755 commented Mar 11, 2024 •
edited by kuhnroyal
Loading

As in reported in #384 and changes already requested in #382, here a few changes to fix support for newer Gradle & Android versions.

This PR provide the minimal changes to support current Gradle and AGP versions. No library or plugin is updated.

  • The package field in AndroidManifest is now auto-generated and the namespace configuration in the build.gradle is required since AGP 8.0
  • I remove the AndroidManifest while there is now empty and useless
  • I also added missing Kotlin JVM options, that was causing me failed builds
  • Finally I removed a duplicated Gradle configuration

This was referenced May 14, 2024
Closed
Closed
kuhnroyal
kuhnroyal reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some comments.
Can you bump the compile SDK to 34 in the same go?

android/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
@Fabi755
Copy link
Contributor Author

Fabi755 commented May 17, 2024

Can you bump the compile SDK to 34 in the same go?

Done. I think we should upgrade the Gradle wrapper, build tools and other dependencies. But maybe in a follow up PR.

kuhnroyal
kuhnroyal approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kuhnroyal kuhnroyal enabled auto-merge (squash) May 17, 2024 12:40
@kuhnroyal kuhnroyal merged commit 3db5b2a into maplibre:main May 17, 2024
6 checks passed
@smallTrogdor
Copy link
Contributor

Thanks for the changes and I guess it made sense to separate this form the other changes I made in #382 - I am however not the biggest fan of this construct to support old AGP versions forever. As soon as this package will allow for breaking changes, this should be done imO.

@kuhnroyal
Copy link
Collaborator

I agree.

@josxha josxha mentioned this pull request May 17, 2024
Merged
@josxha josxha added this to the v0.19.0 milestone May 20, 2024
josxha added a commit to josxha/flutter-maplibre-gl that referenced this pull request May 21, 2024
@josxha
Squashed commit of the following:
b266009 
commit f27bcab
Author: Joscha <[email protected]>
Date:   Sat May 18 23:49:28 2024 +0200

    feat: allow latest `flutter_lints` version (maplibre#419)

commit 8323f55
Author: Joscha <[email protected]>
Date:   Sat May 18 02:00:56 2024 +0200

    feat: add `flutter_lints`, fix or ignore lints (maplibre#414)

    Co-authored-by: Peter Leibiger <[email protected]>

commit e5d95ed
Author: Joscha <[email protected]>
Date:   Fri May 17 23:38:40 2024 +0200

    fix(web): ensure the usage of `maplibre-gl-js` version 4.x.x, remove `_addStylesheetToShadowRoot` (maplibre#409)

commit e617b90
Author: Joscha <[email protected]>
Date:   Fri May 17 16:33:47 2024 +0200

    feat: update package links in pubspec.yaml files (maplibre#413)

commit 68040d4
Author: Joscha <[email protected]>
Date:   Fri May 17 16:25:36 2024 +0200

    chore: delete `pubspec.lock` files (maplibre#412)

commit 3db5b2a
Author: Fabian Keunecke <[email protected]>
Date:   Fri May 17 14:58:33 2024 +0200

    Support newer Gradle versions (maplibre#390)

commit 7cb6521
Author: Joscha <[email protected]>
Date:   Fri May 17 14:53:47 2024 +0200

    feat(web): allow package:js version 0.6.x and 0.7.x (maplibre#410)
@smallTrogdor smallTrogdor mentioned this pull request May 26, 2024
Merged
josxha pushed a commit that referenced this pull request May 27, 2024
@smallTrogdor
chore: build example app with gradle 8 (#430)
a4a88f0 
Since #390, the package can be used with Gradle 8. This is a small PR to
have the example app use Gradle 8 for building (see #382)

Tested with emulator and physical android device.
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 6, 2024
@Fabi755
Support newer Gradle versions (maplibre#390)
ffdc5de
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 6, 2024
@smallTrogdor
chore: build example app with gradle 8 (maplibre#430)
abe40e9 
Since maplibre#390, the package can be used with Gradle 8. This is a small PR to
have the example app use Gradle 8 for building (see maplibre#382)

Tested with emulator and physical android device.
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
@Fabi755
Support newer Gradle versions (maplibre#390)
ad5edc0
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
@smallTrogdor
chore: build example app with gradle 8 (maplibre#430)
22e619a 
Since maplibre#390, the package can be used with Gradle 8. This is a small PR to
have the example app use Gradle 8 for building (see maplibre#382)

Tested with emulator and physical android device.
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
@Fabi755
Support newer Gradle versions (maplibre#390)
344c31d
Remi-deronzier pushed a commit to viamichelin/flutter-maplibre-gl that referenced this pull request Sep 10, 2024
@smallTrogdor
chore: build example app with gradle 8 (maplibre#430)
73f8fea 
Since maplibre#390, the package can be used with Gradle 8. This is a small PR to
have the example app use Gradle 8 for building (see maplibre#382)

Tested with emulator and physical android device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

Android gradle namespace issue Upgrade Android Gradle Plugin to 8.x.x
4 participants
@Fabi755 @smallTrogdor @kuhnroyal @josxha