This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Allow docs to build 3.0.0-pre #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarelM
reviewed
May 19, 2023
| return console.log(err); | ||
| } | ||
| var result = data.replace( | ||
| "export type * from '@maplibre/maplibre-gl-style-spec';", |
There was a problem hiding this comment.
While I understand why this was added, we'll need to find a solution for this in the future. If I understand correctly, all the types from the spec package will not be included in the docs. This isn't optional.
I'm not sure what is the current situation though.
There was a problem hiding this comment.
You are right. At present it's not an issue for the docs though, because non of these types are used here, but I that we should not have these find/replace type workarounds even for docs.
HarelM
approved these changes
May 19, 2023
HarelM
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready, but let's update to the full 3.0.0 when it's out, as this will bump the docs to 3.0.0-pre.6 (overwriting the 2.4.0 online).
Fixes #457
This PR updates the changes in classes in Pre.2 (touch handlers renamed) and Pre.4 (clearStorage tile cache removed) - and the tests accordingly
This PR also introduces a simple find/replace to remove the type-only import/export of all style spec types, which isn't supported in documentationjs at this point. The approach taken is virtually identical to the previous remove-assert.js script which was used to compensate for a lack of json type assertion support in documentationjs when node 18 was introduced:
https://github.com/maplibre/maplibre-gl-js/blob/ad566a6069e6597e26e3685e48bf41a1532858d3/src/index.ts#LL38C1-L39C1