-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): check if event instanceof MouseEvent #5466
feat(events): check if event instanceof MouseEvent #5466
Conversation
015fb5f
to
6370d49
Compare
6370d49
to
21c439e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5466 +/- ##
==========================================
+ Coverage 91.96% 91.98% +0.02%
==========================================
Files 282 282
Lines 39079 39115 +36
Branches 6873 6878 +5
==========================================
+ Hits 35938 35979 +41
+ Misses 3013 3009 -4
+ Partials 128 127 -1 ☔ View full report in Codecov by Sentry. |
46694f8
to
1316f24
Compare
1316f24
to
640cb5c
Compare
640cb5c
to
b11844f
Compare
Tests were ok in local, I will check during the day why it fails. |
58ed29e
to
36eadfd
Compare
Should I update the bundle size test, or will a collaborator handle it? |
Please update the build size. Thanks! |
36eadfd
to
1911789
Compare
Everything is ready should I rebase on main ? @HarelM |
Yes, please resolve conflicts. |
1911789
to
180b192
Compare
check if event is instance of MouseEvent in map_event.ts same for event.ts Fix 5464
180b192
to
736e243
Compare
Fix an error that could happen if a instance of Event is dispatched with MouseEvent types. This error has been encountered only when bots were crawling a website where a maplibre map was instanced.
Launch Checklist
CHANGELOG.md
under the## main
section.