Fix Circle Layer hitbox in Globe projection mode #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaswoj
changed the title
HarelM
reviewed
Mar 8, 2025
| @@ -75,10 +76,11 @@ function getPixelPosMatrix(transform, tileID: OverscaledTileID) { | |||
| const t = mat4.create(); | |||
| mat4.translate(t, t, [1, 1, 0]); | |||
| mat4.scale(t, t, [transform.width * 0.5, transform.height * 0.5, 1]); | |||
| if (transform.calculatePosMatrix) { // Globe: TODO: remove this hack once queryRendererFeatures supports globe properly | |||
| if ('calculatePosMatrix' in transform) { // Globe: TODO: remove this hack once queryRendererFeatures supports globe properly | |||
There was a problem hiding this comment.
Can we have pixel to tile units support both mercator and globe and remove this if statement and todo?
|
When I looked at this feature I saw that the offset code is also broken. |
|
Thanks for the review! I’ll look into whether circle-offset works on the glove projection, write a quick blurb on what it’d take to fully resolve the TODO comment, and get back to you early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5255 where circle layers have extremely small hitboxes when using the "globe" projection at low zoom levels.
Problem
When using Circle layers in the "globe" projection,
queryRenderedFeaturesonly works over tiny fraction of the circle rather than the entire rendered feature. This makes interactive maps with circle layers frustrating to use at low zoom levels.Root Cause
The issue stems from the
pixelPosMatrixcalculation inqueryRenderedFeatures. The implementation wasn't properly handling globe projection, leading to incorrect hit testing calculations inCircleStyleLayer#queryIntersectsFeature.Solution
This PR updates the
getPixelPosMatrixfunction inquery_features.tsto account for the proper scale transformation when mapping between screen space and tile units. Deeper architectural changes are needed to say thatqueryRenderedFeaturesfully supports theglobeprojection but this addresses the immediate bug with a minimally intrusive fix.Testing
This should make Circle layers properly interactive in all projection modes.
Launch Checklist
Include before/after visuals or gifs if this PR includes visual changes.Document any changes to public APIs.Post benchmark scores.These should not change as a resultCHANGELOG.mdunder the## mainsection.