Android surface pre-rotation

[adrian-cojocaru]

Add a surface transform at the end of each vertex shader to eliminate the compositor pass added by the OS (needed to display the framebuffer correctly).
A great article that describes all the benefits and implications: https://developer.android.com/games/optimize/vulkan-prerotation

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2955-compared-to-main.txt

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2955-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.4Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2955-compared-to-legacy.txt

[github-actions]

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0115         -0.0115             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2955-compared-to-main.txt

[louwers]

Really cool, also thanks for sharing the link.

Any way we can test this as part of the instrumentation tests?

[adrian-cojocaru]

After some quick searching looks like OrientationChangeTest and MapSnapshotterTest can be combined to get bitmaps and compare them with a rotated baseline or in pairs SCREEN_ORIENTATION_PORTRAIT/SCREEN_ORIENTATION_REVERSE_PORTRAIT and SCREEN_ORIENTATION_LANDSCAPE/SCREEN_ORIENTATION_REVERSE_LANDSCAPE.