fix: disable library code signing

Remove withoutSignature build phase in plugin.
maplibre · Sep 18, 2024 · 22030dd · 22030dd
1 parent 016b44a
commit 22030dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 25 deletions.
diff --git a/ios/RCTMLN.xcodeproj/project.pbxproj b/ios/RCTMLN.xcodeproj/project.pbxproj
@@ -656,7 +656,8 @@
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
-				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
+				CODE_SIGN_IDENTITY = "";
+				CODE_SIGNING_REQUIRED = NO;
 				COPY_PHASE_STRIP = NO;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;

diff --git a/plugin/src/withMapLibre.ts b/plugin/src/withMapLibre.ts
@@ -129,29 +129,6 @@ export function setExcludedArchitectures(project: XcodeProject): XcodeProject {
   return project;
 }
 
-const withoutSignatures: ConfigPlugin = (config) => {
-  const shellScript = `if [ "$XCODE_VERSION_MAJOR" = "1500" ]; then
-    echo "Remove signature files (Xcode 15 workaround)";
-    rm -rf "$CONFIGURATION_BUILD_DIR/MapLibre.xcframework-ios.signature";
-  fi`;
-  return withXcodeProject(config, async (config) => {
-    const xcodeProject = config.modResults;
-
-    xcodeProject.addBuildPhase(
-      [],
-      "PBXShellScriptBuildPhase",
-      "Remove signature files (Xcode 15 workaround)",
-      null,
-      {
-        shellPath: "/bin/sh",
-        shellScript,
-      },
-    );
-
-    return config;
-  });
-};
-
 const withExcludedSimulatorArchitectures: ConfigPlugin = (c) => {
   return withXcodeProject(c, (config) => {
     config.modResults = setExcludedArchitectures(config.modResults);
@@ -160,7 +137,7 @@ const withExcludedSimulatorArchitectures: ConfigPlugin = (c) => {
 };
 
 const withMapLibre: ConfigPlugin = (config) => {
-  config = withoutSignatures(withExcludedSimulatorArchitectures(config));
+  config = withExcludedSimulatorArchitectures(config);
   return withCocoaPodsInstallerBlocks(config);
 };