Fix SQL comments when func or table is pre-configured #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comment is set on a table or a function, and that tbl/func is pre-configured as part of the config file, the SQL comment is currently ignored. This commit does NOT fix the issue, only identifies it and adds an integration test. Note that it will pass at the moment, and once fixed, the expected result files will change.
sharkAndshark
approved these changes
Dec 7, 2023
nyurik
changed the title
nyurik
changed the title
nyurik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a SQL comment is set on a table or a function to customize tilejson, and that tbl/func is pre-configured as part of the config file, the comment was silently ignored. Now both table and function cases are handled correctly.
Also, update docs to not include function parameters - makes SQL example a bit simpler.
Thanks @jjcfrancisco for reporting!
Fixes: #1044