Update macos runner #1165
Update macos runner #1165
Conversation
|
Thx @nyurik ! I will try Ngnix on my local M1 MacBook and update this PR then. |
.github/workflows/ci.yml
Outdated
| @@ -248,7 +248,7 @@ jobs: | |||
| - target: debian-x86_64 | |||
| os: ubuntu-latest | |||
| - target: x86_64-apple-darwin | |||
| os: macos-12 # x64 CPU | |||
| os: macos-14 # M1 CPU | |||
There was a problem hiding this comment.
You don't want M1 CPU here because we are building x86 target
There was a problem hiding this comment.
Oh ok. I thought we can build x86 target on M1, can we?
There was a problem hiding this comment.
I thought we could generate x86 and arm target both on M1, I'm not sure.
There was a problem hiding this comment.
Oh I see I see.
There was a problem hiding this comment.
Seems M1 could build and run(by Rosetta) x86_64-apple-darwin, but it's not the best choice. I've already switch back to macos-12 runner. Thx @nyurik
| @@ -320,6 +320,7 @@ jobs: | |||
| - name: Start HTTP Server (MacOS, no Docker) | |||
| if: runner.os == 'macos' | |||
| run: | | |||
| mkdir -p /usr/local/etc/nginx | |||
There was a problem hiding this comment.
i'm not sure we should create a directory that nginx doesn't know about. We may have to just download nginx from somewhere... anyway, i think it might not be worth our time at this stage - until they install nginx on -13 and -14 the same way they have it on -12 (latest).
There was a problem hiding this comment.
We could do more when macos-14 is stable, now is beta. There are many issues bigger than #1162.
Try to fix #1162