Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix curl url for linux mbtiles demo #1387

Merged
merged 2 commits into from
Jun 29, 2024
Merged

fix curl url for linux mbtiles demo #1387

merged 2 commits into from
Jun 29, 2024

Conversation

tbo47
Copy link
Contributor

@tbo47 tbo47 commented Jun 28, 2024

No description provided.

@sharkAndshark
Copy link
Collaborator

Thx!!!! @tbo47

@sharkAndshark
Copy link
Collaborator

sharkAndshark commented Jun 28, 2024 •
edited
Loading

Maybe we should update the links of windows and macOS either?
If not, the user would be redirected to the web interface of this MBTiles. Then they could click the Download raw file button. @nyurik

@tbo47
Copy link
Contributor Author

tbo47 commented Jun 28, 2024

Maybe we should update the links of windows and macOS either? If not, the user would be redirected to the web interface of this MBTiles. Then they could click the Download raw file button. @nyurik

yes, I didn't update the Windows and MacOs ones for this reason.

@nyurik
Copy link
Member

nyurik commented Jun 28, 2024

@tbo47 thx for the PR. Could you explain why the original was not working for you? I tried it locally, and the original works just as well, and IMO is a better (authoritative) URL.

@tbo47
Copy link
Contributor Author

tbo47 commented Jun 29, 2024 

➜  /tmp curl -L -O https://github.com/maplibre/martin/blob/main/tests/fixtures/mbtiles/world_cities.mbtiles
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  280k    0  280k    0     0   270k      0 --:--:--  0:00:01 --:--:--  270k
➜  /tmp head world_cities.mbtiles
<!DOCTYPE html>
<html
  lang="en"

and

➜  /tmp apt info curl
Package: curl
Version: 8.8.0-1~bpo12+1

I'm on debian stable with backport activated.

@nyurik
Copy link
Member

nyurik commented Jun 29, 2024

Ah, sorry, i should have actually looked at the result. The raw button actually points to this URL: https://github.com/maplibre/martin/raw/main/tests/fixtures/mbtiles/world_cities.mbtiles -- I still think pointing to the github site is better than resolve the redirect and pointing to githubusercontent

@nyurik nyurik merged commit b814ac0 into maplibre:main Jun 29, 2024
2 checks passed
@nyurik
Copy link
Member

nyurik commented Jun 29, 2024

I also fixed the mac and windows download links because the link to the release code (i.e. zip file) starts downloading right away - so for consistency we will want the same thing.

@nyurik
Copy link
Member

nyurik commented Jun 29, 2024

And once again - huge thx for @tbo47 for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

@sharkAndshark sharkAndshark sharkAndshark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbo47 @sharkAndshark @nyurik