Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:added a postgres version check #1427

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Jul 23, 2024

  • adds a postgres version check
  • added a testcase (using testcontainers) that the version is parsed correctly

Resolves #1230 (I think at this point the PR can be considered unasigned again, feel free to reject otherwise. Don't want to step on peoples toes ^^)
Resolves #1229 (by using the minumum supported postgres version for postgis)

@nyurik
Copy link
Member

nyurik commented Oct 20, 2024

thanks! test containers is an interesting feature, perhaps should use it in some other places too.

@nyurik nyurik merged commit 8ac8ef5 into maplibre:main Oct 20, 2024
18 of 19 checks passed
@CommanderStorm CommanderStorm deleted the pg-version-check branch October 20, 2024 10:26
@CommanderStorm
Copy link
Collaborator Author

Bit of an overlooked downside:
since it requires docker, the CI runners for Mac/windows would need to install this manually, but otherwise a really great tool for testing, can only recommend..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect old postgresql versions and warn user db error: ERROR: column ix.indnkeyatts does not exist
2 participants