Restrict IDs, optimize single-source req #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nyurik
commented
Dec 14, 2022
nyurik
commented
- Ensure the source ID only contains ascii alphanumerics, dots, dashes, and underscores.
- optimize the most common case of getting a single source
- optimize the case of sources with no query parameters
nyurik
force-pushed
the
perf
branch
2 times, most recently
from
4cd0ef5 to
5db819d
Compare
* Ensure the source ID only contains ascii alphanumerics, dots, dashes, and underscores. * optimize the most common case of getting a single source * optimize the case of sources with no query parameters
stepankuzmin
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.