Improve SSL support #567
Merged
Improve SSL support #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 57.92% // Head: 57.89% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 57.92% 57.89% -0.04%
==========================================
Files 29 30 +1
Lines 2510 2546 +36
==========================================
+ Hits 1454 1474 +20
- Misses 1056 1072 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nyurik
force-pushed
the
fix-ssl
branch
6 times, most recently
from
f0c48e2 to
3eca837
Compare
* remove `danger_accept_invalid_certs` -- turns out that behavior is expected by default unless ssl mode is set to verify - which upstream lib does not support (yet) - PR submitted. * added connection_timeout_ms option for postgres and set it to 5 seconds by default. This way it will fail out earlier. * added error reporting to bb8 - but it is currently broken upstream - not sure we can fix it easily, so may need to switch to deadpool later. * added docker-based TLS test (horray!) - wasn't trivial at all, despite ending up fairly simple. * important: if ca root file is set, it will be verified. The host will never be verified.
stepankuzmin
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #496
psql-- by default, if SSL is available on the server, it will be used, even though it will not verify that the server has a valid SSL certificatePGSSLCERT,PGSSLKEY, andPGSSLROOTCERTenv vars (and corresponding config keys) - same as psql.?sslmode=verify-caandverify-full(just like psql). The verify modes require root and/or client cert & key.danger_accept_invalid_certs-- turns out that behavior is expected by default unless ssl mode is set to verify - which upstream lib does not support - PR submitted.