Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views handling #571

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Views handling #571

merged 3 commits into from
Feb 8, 2023

Conversation

cthiange
Copy link
Contributor

@cthiange cthiange commented Feb 7, 2023

  • Adds a view to points1.sql fixture
  • Replaces table with view in log statements relating to views

@codecov-commenter
Copy link

Codecov Report

Base: 58.70% // Head: 58.67% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a220588) compared to base (612a8d3).
Patch coverage: 33.33% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   58.70%   58.67%   -0.04%     
==========================================
  Files          30       30              
  Lines        2584     2589       +5     
==========================================
+ Hits         1517     1519       +2     
- Misses       1067     1070       +3     
Impacted Files Coverage Δ
src/pg/configurator.rs 44.95% <0.00%> (-0.58%) ⬇️
src/pg/table_source.rs 44.80% <100.00%> (+0.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nyurik nyurik merged commit 22bf200 into maplibre:main Feb 8, 2023
@nyurik
Copy link
Member

nyurik commented Feb 8, 2023

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants