Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] Use table name as the layer ID for PG tables #598

Merged
merged 2 commits into from
Mar 13, 2023
Merged

[breaking] Use table name as the layer ID for PG tables #598

merged 2 commits into from
Mar 13, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Mar 11, 2023 •
edited
Loading

  • [BREAKING] Use source ID (table name) as the default layer ID, instead of schema.table.column
  • Add support for the optional layer_id table config parameter

Fix #595

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.10 ⚠️

Comparison is base (fc3057f) 59.23% compared to head (ba656cb) 59.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   59.23%   59.14%   -0.10%     
==========================================
  Files          30       30              
  Lines        2750     2756       +6     
==========================================
+ Hits         1629     1630       +1     
- Misses       1121     1126       +5
Impacted Files Coverage Δ
src/pg/table_source.rs 41.84% <0.00%> (-1.54%) ⬇️
src/pg/config_table.rs 97.50% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nyurik nyurik requested a review from stepankuzmin March 11, 2023 21:45
@nyurik nyurik mentioned this pull request Mar 11, 2023
Closed
nyurik added 2 commits March 12, 2023 23:57
@nyurik
[breaking] Use table name as the layer ID for PG tables
5a06d5a 
* Add support for the layer_id config parameter
* By default, layer_id will be the same as the table name
* [BREAKING] Do not use full table id (`schema.table.column`) for layer id
@nyurik
use id as the default
ba656cb
stepankuzmin
stepankuzmin approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nyurik nyurik merged commit 50462d5 into maplibre:main Mar 13, 2023
@nyurik nyurik deleted the layer_id branch March 13, 2023 11:41
@nyurik nyurik mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector tiles loaded but not displayed in browser
3 participants
@nyurik @codecov-commenter @stepankuzmin