Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta-get functionality #701

Merged
merged 8 commits into from
Jun 3, 2023
Merged

Add meta-get functionality #701

merged 8 commits into from
Jun 3, 2023

Conversation

upsicleclown
Copy link
Collaborator

@upsicleclown upsicleclown commented Jun 2, 2023 •
edited
Loading

  • Add functionality to retrieve a metadata value in an mbtiles file by key; simple implementation for one of the items in Expand mbtiles binary #667
  • Also, disable TTY in docker-up just target

nyurik
nyurik reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks! I left a few suggestions

martin-mbtiles/Cargo.toml Outdated Show resolved Hide resolved
docs/src/tools.md Outdated Show resolved Hide resolved
docs/src/tools.md Outdated Show resolved Hide resolved
docs/src/tools.md Outdated Show resolved Hide resolved
docs/src/tools.md Outdated Show resolved Hide resolved
docs/src/tools.md Outdated Show resolved Hide resolved
@nyurik nyurik enabled auto-merge (squash) June 3, 2023 00:35
nyurik
nyurik approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!!!

@nyurik nyurik merged commit 78e67c3 into maplibre:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upsicleclown @nyurik