Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding semapv:MappingInversion to SEMAPV #23

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 2, 2023

Fixes #22

This PR adds semapv:MappingFlipping to the vocabulary with a bunch of suitable synonyms.

Thank your for reviewing.

semapv-terms.tsv Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented Mar 2, 2023

Overall I fully support this update, I just made a few on the code and below.

Should there be different justifications for reflective inversions (A skos:exactMatch B inverts to B skos:exactMatch A) and non-reflexive inversions (A skos:broaderMatch B inverts to B skos:narrowMatch A)?

based on suggestion of @cthoyt on #23
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the title of the PR before merging

@matentzn matentzn changed the title Adding semapv:MappingFlipping to SEMAPV Adding semapv:MappingInversion to SEMAPV Mar 2, 2023
@matentzn matentzn merged commit c28284f into main May 4, 2023
@matentzn matentzn deleted the mapping-flipping branch May 4, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semapv:MappingInversion
2 participants