Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should unmapped elements be indicated? #28

Closed
cmungall opened this issue Aug 18, 2020 · 13 comments · Fixed by #381
Closed

How should unmapped elements be indicated? #28

cmungall opened this issue Aug 18, 2020 · 13 comments · Fixed by #381

Comments

@cmungall
Copy link
Contributor

I frequently want to be able to state: I have looked in object_source for a matching or close concept to subject_id but am confident there is nothing.

How should I state this?

Can we make object_id/name nullable (where we have a convention that '' in the TSV is null)?

alternatively we could have a CURIE/URI for NoMapping, analogous to owl:Thing.

@wdduncan we need this for the nmdc sssom

I'm also using a pseudo-sssom for cob-to-external where I have blank entries for not mapped

@wdduncan
Copy link

I like the idea of NoMapping, or perhaps ssssom:NoMapping.

@matentzn
Copy link
Collaborator

My main worry is that this statement is a statement on mapping level that requires for its interpretation the context of the mapping (mapping set). My main use case for SSSOM requires the ability to mix and match mappings, which sort of decontextualises them. I guess we could say that the interpretation of sssom:NoMapping is "no mapping in source", and require the object_source to be specified- when sssom:NoMapping is used. We could also use sssom:Nothing instead of noMappig to retain a bit the "object-ness" of the terminology in the object_id column.. I dont mind either way. Something like:

subject_id relation_id object_id match_type object_source
HPO:001 owl:equivalentTo sssom:Nothing sssom:HandCurated mp.owl

@wdduncan
Copy link

We could also use sssom:Nothing instead of noMappig to retain a bit the "object-ness"
This makes sense to me!

Also, you could include a column that for whether a mapping exists. "1" means a mapping does, "0" means a mapping does not. Personally, I prefer sssom:Nothing.

@mellybelly
Copy link

Needs to be clear that a mapping was sought and not found, regardless of implementation.

@cmungall
Copy link
Contributor Author

cmungall commented Aug 19, 2020 via email

@cmungall
Copy link
Contributor Author

cmungall commented Aug 19, 2020 via email

@cmungall
Copy link
Contributor Author

Maybe rather than sssom:Nothing, something like sssom:NoTermFound (to avoid confusing with owl:Nothing)

@wdduncan
Copy link

Do we want a special predicate for such cases? E.g.: sssom:noMatch

@cmungall
Copy link
Contributor Author

cmungall commented Oct 13, 2020 via email

@matentzn
Copy link
Collaborator

matentzn commented May 31, 2021

This tickets discusses three things:

  1. How to declare that there is no mapping of a kind
  2. How to declare that a mapping is false (negated mapping)
  3. How to capture that the above were determined

For 1, the going proposal is:

subject_id relation_id object_id match_type object_source
HP:001 owl:equivalentTo sssom:NoTermFound sssom:HumanCuration mp.owl

to indicate that given the term HP:001, there was no term in the object_source that a human curator could find would map. Are we all in agreement of that?

For 2 EDIT: moved discussion to #40

@matentzn
Copy link
Collaborator

The negated mapping question is discussed in #40 so this ticket is now purely about the question how to specify unmapped elements.

@matentzn
Copy link
Collaborator

matentzn commented Sep 1, 2021

Vote: Proposal for modelling unmapped elements.

subject_id relation_id object_id match_type object_source
HP:001 owl:equivalentTo sssom:NoTermFound sssom:HumanCuration mp.owl

To say that: "According to a human curator, there was no term in object_source that could be mapped to HP:001 using the owl:equivalentTo predicate".

  • 👍: Agree with proposal
  • 👎: Do not agree with proposal (see comment for alternative idea).

@matentzn
Copy link
Collaborator

matentzn commented Aug 3, 2024

Documenting the outcome of the Vote for the future:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants