Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit for packaging #199

Merged
merged 14 commits into from
Jun 7, 2022
Merged

Edit for packaging #199

merged 14 commits into from
Jun 7, 2022

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jun 6, 2022 •
edited
Loading

  • Moved src and project dir out of the sssom_schema dir. So basically reverting back to the autogenerated file structure.
  • Renamed linkml to schema and moved it under the datamodel dir

Full explanation: linkml/linkml#797 (comment)

@hrshdhgd hrshdhgd requested a review from matentzn June 6, 2022 18:52
matentzn
matentzn reviewed Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I fixed one issue with the schema and adjusted the makefile to the new layout.

  • all the generated project docs are missing - are these just gitignored?

pyproject.toml Show resolved Hide resolved
@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Jun 7, 2022

  • all the generated project docs are missing - are these just gitignored?

That's not intended. Where are they supposed to reside?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Jun 7, 2022 •
edited
Loading

Aah ... apparently they were always in .gitignore. I did not actively do it. Seems like it has been there for the last 2 months. Lines 1 and 2 of .gitignore

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Jun 7, 2022 •
edited
Loading

If all of them are autogenerated then the GitHub workflow will take care of their generation, that should not be an issue. If there are files that were manually created, we need to version control them.

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Jun 7, 2022

Also, we need to decide if the entire schema folder is needed or needs to be deleted (or just sssom_datamodel.py)

@hrshdhgd hrshdhgd merged commit f0bd9ef into master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrshdhgd @matentzn