-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues around canonical ordering #285
Conversation
SHOULD/MUST fixes for canoical order SOME filename related clarifications BUILT in prefixes comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, but please note the remark about the SEMAPV prefix URL. The one given in the examples’ curie map differs from the one used in SEMAPV and the one registered on the bioregistry.
|
@matentzn , I noticed that the |
Does it make sense, instead to add a pip install -U sssom to the action to ensure its always on the most up to date state? |
I agree! That's the ideal scenario. If you mean the docker image has the most up-to-date version of |
In this case, can you do it on this PR and see if it works? |
But does the Docker image already have the latest version of |
@hrshdhgd feel free to merge, its fine! |
Partially adresses #283
docs/
have been added/updated if necessaryCHANGELOG.md has been updated.
Applies canonical sort ordering to all examples files
Downgrades the necessity of applying the canonical column order from MUST to SHOULD
Documents clearly that built-in prefixes MUST NOT be redefined