Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec.md: TSV entity references #363

Closed
wants to merge 1 commit into from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Apr 18, 2024

Does not address an issue, but relevant context is: here

Changes

  • Add: Subsection in TSV subsection about entity reference validity.

Checks

  • docs/ have been added/updated if necessary

Not applicable:

  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

- Add: Subsection in TSV subsection about entity reference validity.
@@ -362,6 +362,8 @@ This precludes spurious diffs in a git setting, which is an important concern fo

Note that only metadata elements permissible in a global context (G, or L/G) can be used in the metadata-file.

**Entity references**: All identifiers in a SSSOM/TSV file (both in the metadata section and in the TSV columns) MUST be in CURIE form. The use of full-length identifiers is officially not supported.
Copy link
Contributor Author

@joeflack4 joeflack4 Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change

@gouttegd I copied pretty much ver batim what you suggested here. Seemed good enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve already put that change in my #362 PR. It just need to be approved and merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good to hear, thanks! I'll close this, tehn.

@joeflack4 joeflack4 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants