-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SSSOM Logo in docs #367
Conversation
The SSSOM Logo has had a typo for all of its life: ontology instead of "ontological" to express the fact that this is not just about "mappings across ontologies", but "semantic" mappings in general. @sagehrke has updated the logos to that end - big thanks.
The SSSOM logo had a long standing typo, ontology to ontological, which is hereby fixed.
So, should the standard really have been called “Simple Standard for Sharing Semantic Mappings” (SSSSM)? And here I thought that SSSOM was difficult to pronounce… :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection, but is there a reason why we don’t commit the logo file into this repository?
Having the logo hosted elsewhere means it can disappear anytime for reasons that are beyond our control. In fact, this is exactly what has already happened: the logo is currently not visible on the public website, because the repository hosting it has changed.
Having the logo stored within this repository would prevent that from happening again.
You are laughing now but I actually suggested this. Some people in Monarch were already mad we had settled for SSSOM, being the "worst of all possible acronyms", "terrible", "how could you", but when I came to them and suggested "SSSSM" and to pronounce it something like "sim" they blocked me with very clear words. The schema extension could even be called |
Pity. They should have recognized that at least you didn’t come up with “SSSSMS” (Simple Standard for Sharing Semantic Mapping Sets). :D |
As per suggestion from @gouttegd we move the SSSOM banner to this repo here to protect it from upstream changes (like repository moves or file renamings).
Haha. I updated committed the logo and updated the references. Thanks for the suggestion! |
Thanks, but without any precision anywhere, the file in We need either to make sure that the illustrator is happy with the terms change, or add a notice somewhere in the README to state that the logo file is not covered by the terms set forth in LICENSE. |
Use of all logos in this repo is blanket permitted (without written permission) by members of the internal Monarch team and all collaborators on Monarch flagship products |
We add a COPYING section to the README file to explicitly state that the overall project is published under the terms of the 3-clause BSD license. We use that section to explicitly state that, as an exception, the logo file is _not_ distributed under the terms of the 3-clause BSD license and may _not_ be used by anyone outside of Monarch members and collaborators.
The path should be relative to spec.md, which is in the same directory as the image folder Co-authored-by: Emily Hartley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
@gouttegd Do you approve as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
The SSSOM Logo has had a typo for all of its life: ontology instead of "ontological" to express the fact that this is not just about "mappings across ontologies", but "semantic" mappings in general. @sagehrke has updated the logos to that end - big thanks 🎉
docs/
have been added/updated if necessarymake test
has been run locally