-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace semantic_similarity_* slots by similarity_* slots #386
Conversation
…ty_*` The slot definitions for similarity_score and similarity_measure already exist, that is why they are not in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to update files that are dependent on this YAML change. For example sssom_schema.py and others (if any). Run make all
I think?
Lines 44 to 53 in d2b9d7e
all: gen-project gendoc gen-excel get-context | |
%.yaml: gen-project | |
deploy: all mkd-gh-deploy | |
# generates all project files | |
gen-project: $(PYMODEL) | |
$(RUN) gen-project \ | |
--exclude owl \ | |
-d $(DEST) $(SOURCE_SCHEMA_PATH) && mv $(DEST)/*.py $(PYMODEL) | |
thank you @ehartely Co-authored-by: Emily Hartley <[email protected]>
Fixes #385
docs/
have been added/updated if necessarymake test
has been run locallytests have been added/updated (if applicable)If you are proposing a change to the SSSOM metadata model, you must
examples/
see_also
field of the linkml modelsee_also
field of the linkml model