Add the predicate_type slot to Mapping and MappingSet classes.
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `predicate_type` slot has been _defined_ but never _used_ in any classes. Presumably this is an oversight, so we add it here to the Mapping and MappingSet classes. We make it a “propagapable” slot, for consistency with the `subject_type` and `object_type` slots. closes #404
matentzn
approved these changes
Dec 20, 2024
jamesamcl
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#404]
docs/have been added/updated if necessarymake testhas been run locallytests have been added/updated (if applicable)If you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsee_alsofield of the linkml modelThe
predicate_typeslot has been defined but never used in any classes. Presumably this is an oversight, so we add it here to the Mapping and MappingSet classes. We make it a “propagatable” slot, for consistency with thesubject_typeandobject_typeslots.