timelesslounge#74 Enhancing the DoubleQuotesOnly rules

.rultor.yml

@@ -12,8 +12,7 @@ install: |-
   ./install_db.sh
 merge:
   script: |-
-    chmod +x ./checkstyle.sh
-    ./checkstyle.sh
+    python checkstyle.py
     python check_pylint.py
     pytest -vv
     pdd -f /dev/null -v

checkstyle.py

@@ -0,0 +1,34 @@
+"""
+Scripts to enforce certain code style rules.
+"""
+import glob
+import re
+import sys
+
+
+def double_qoutes_only():
+    """ DoubleQuotesOnly; Forbid usage of single-quoted strings """
+    for filename in glob.iglob("./timeless/**/*.py", recursive=True):
+        with open(filename, "r+") as f:
+            data = f.read()
+            pattern = "['](?=[^\"]*(?:\"[^\"]*\"[^\"]*)*$)"
+            prev_line = -1
+            prev_offset = 0
+            match_found = False
+            for m in re.finditer(pattern, data):
+                if not match_found:
+                    print("Single-quotes are forbidden in .py files!")
+                    match_found = True
+                start = m.start()
+                lineno = data.count('\n', 0, start) + 1
+                offset = start - data.rfind('\n', 0, start)
+                word = m.group(0)
+                if prev_line == lineno:
+                    print("%s(%s,%s-%s): %s" %
+                          (f.name, lineno, prev_offset, offset, word))
+                prev_line = lineno
+                prev_offset = offset
+            if match_found:
+                sys.exit(2)
+
+double_qoutes_only()

timeless/__init__.py

@@ -1,8 +1,5 @@
 """This file contains all functions needed to create
 a new Flask app for timeless
-@todo #69:30min Enhance the "DoubleQuotesOnly" rule from checkstyle.sh,
- to allow single-quoted strings as long as they are contained within
- another double-quoted String.
 """
 
 import os

timeless/restaurants/floors/views.py

@@ -31,7 +31,7 @@ def create():
     """ Create new floor """
     if request.method == "POST":
         flash("Create not yet implemented")
-    action = 'create'
+    action = "create"
     return render_template(
         "restaurants/floors/create_edit.html",
         action=action
@@ -44,7 +44,7 @@ def edit(id):
     """ Edit floor with id """
     if request.method == "POST":
         flash("Edit not yet implemented")
-    action = 'edit'
+    action = "edit"
     return render_template(
         "restaurants/floors/create_edit.html",
         action=action