-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1493449. Change the default credentials mode for module scripts f…
…rom 'omit' to 'same-origin'. r=farre The tests come directly from web-platform-tests/wpt#13176 and web-platform-tests/wpt#13245 Differential Revision: https://phabricator.services.mozilla.com/D7113 UltraBlame original commit: e2ec1eeb812d2a3178c303e9ba5538e0d2264bec
- Loading branch information
Showing
7 changed files
with
113 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...pting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [dynamic-imports-credentials.sub.html] | ||
| [Dynamic imports should be loaded with or without the credentials based on the same-origin-ness and the parent script's crossOrigin attribute] | ||
| expected: FAIL | ||
| bug: 1342012 |
1 change: 1 addition & 0 deletions
1
...pting-1/the-script-element/module/dynamic-import/dynamic-imports-fetch-error.sub.html.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| [dynamic-imports-fetch-error.sub.html] | ||
| [import(): error cases occuring during fetching] | ||
| expected: FAIL | ||
| bug: 1342012 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
...scripting-1/the-script-element/module/dynamic-import/dynamic-imports-credentials.sub.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <!DOCTYPE html> | ||
| <meta charset="utf-8"> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/common/get-host-info.sub.js"></script> | ||
|
|
||
| <script type="text/javascript"> | ||
| host_info = get_host_info(); | ||
|
|
||
| document.cookie = 'same=1'; | ||
|
|
||
| const setCookiePromise = fetch( | ||
| 'http://{{domains[www2]}}:{{ports[http][0]}}/cookies/resources/set-cookie.py?name=cross&path=/html/semantics/scripting-1/the-script-element/module/', | ||
| { | ||
| mode: 'no-cors', | ||
| credentials: 'include', | ||
| }); | ||
|
|
||
| const windowLoadPromise = new Promise(resolve => { | ||
| window.addEventListener('load', () => { | ||
| resolve(); | ||
| }); | ||
| }); | ||
|
|
||
| promise_test(t => { | ||
| const iframe = document.createElement('iframe'); | ||
|
|
||
| return Promise.all([setCookiePromise, windowLoadPromise]).then(() => { | ||
| const messagePromise = new Promise(resolve => { | ||
| window.addEventListener('message', event => { | ||
| resolve(); | ||
| }); | ||
| }); | ||
|
|
||
| iframe.src = '../resources/dynamic-import-credentials-iframe.sub.html'; | ||
| document.body.appendChild(iframe); | ||
|
|
||
| return messagePromise; | ||
| }).then(() => { | ||
| const w = iframe.contentWindow; | ||
|
|
||
| assert_equals(w.sameOriginNoneDynamicDescendant, 'found', | ||
| 'Dynamic descendant modules should be loaded with the credentials when the crossOrigin attribute is not specified and the target is same-origin'); | ||
| assert_equals(w.sameOriginAnonymousDynamicDescendant, 'found', | ||
| 'Dynamic descendant modules should be loaded with the credentials when the crossOrigin attribute is specified with "anonymous" as its value and the target is same-origin'); | ||
| assert_equals(w.sameOriginUseCredentialsDynamicDescendant, 'found', | ||
| 'Dynamic descendant modules should be loaded with the credentials when the crossOrigin attribute is specified with "use-credentials" as its value and the target is same-origin'); | ||
| assert_equals(w.crossOriginNoneDynamicDescendant, 'not found', | ||
| 'Dynamic descendant modules should not be loaded with the credentials when the crossOrigin attribute is not specified and the target is cross-origin'); | ||
| assert_equals(w.crossOriginAnonymousDynamicDescendant, 'not found', | ||
| 'Dynamic descendant modules should not be loaded with the credentials when the crossOrigin attribute is specified with "anonymous" as its value and the target is cross-origin'); | ||
| assert_equals(w.crossOriginUseCredentialsDynamicDescendant, 'found', | ||
| 'Dynamic descendant modules should be loaded with the credentials when the crossOrigin attribute is specified with "use-credentials" as its value and the target is cross-origin'); | ||
| }); | ||
| }, 'Dynamic imports should be loaded with or without the credentials based on the same-origin-ness and the parent script\'s crossOrigin attribute'); | ||
| </script> | ||
| <body> | ||
| </body> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...cripting-1/the-script-element/module/resources/dynamic-import-credentials-iframe.sub.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <!DOCTYPE html> | ||
| <script type="module"> | ||
| import("./check-cookie.py?id=sameOriginNoneDynamicDescendant&cookieName=same"); | ||
| </script> | ||
| <script type="module" crossOrigin="anonymous"> | ||
| import("./check-cookie.py?id=sameOriginAnonymousDynamicDescendant&cookieName=same"); | ||
| </script> | ||
| <script type="module" crossOrigin="use-credentials"> | ||
| import("./check-cookie.py?id=sameOriginUseCredentialsDynamicDescendant&cookieName=same"); | ||
| </script> | ||
| <script type="module"> | ||
| import("http://{{domains[www2]}}:{{ports[http][0]}}/html/semantics/scripting-1/the-script-element/module/resources/check-cookie.py?id=crossOriginNoneDynamicDescendant&cookieName=cross"); | ||
| </script> | ||
| <script type="module" crossOrigin="anonymous"> | ||
| import("http://{{domains[www2]}}:{{ports[http][0]}}/html/semantics/scripting-1/the-script-element/module/resources/check-cookie.py?id=crossOriginAnonymousDynamicDescendant&cookieName=cross"); | ||
| </script> | ||
| <script type="module" crossOrigin="use-credentials"> | ||
| import("http://{{domains[www2]}}:{{ports[http][0]}}/html/semantics/scripting-1/the-script-element/module/resources/check-cookie.py?id=crossOriginUseCredentialsDynamicDescendant&cookieName=cross"); | ||
| </script> | ||
|
|
||
|
|
||
| <script type="text/javascript"> | ||
| window.addEventListener('load', event => { | ||
| window.parent.postMessage({}, '*'); | ||
| }); | ||
| </script> |